Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Path once and for all. #1229

Closed
fulmicoton opened this issue Dec 2, 2021 · 0 comments · Fixed by #1231
Closed

Resolve Path once and for all. #1229

fulmicoton opened this issue Dec 2, 2021 · 0 comments · Fixed by #1231
Labels
enhancement good first issue low priority

Comments

@fulmicoton
Copy link
Collaborator

When using a relative path, we end up calling the getcwd syscalls 8 times per commit with the mmapdirectory.
Overall we end up losing ~0.1ms on this.

It is not too terrible but still... It would be nicer to canonicalize our root Path once and for all when we open the directory.
saroh added a commit to saroh/tantivy that referenced this issue Dec 6, 2021
@saroh
canonicalize path when opening MmapDirectory
8bca958 
fixes quickwit-oss#1229
@saroh saroh mentioned this issue Dec 6, 2021
Merged
2 tasks
saroh added a commit to saroh/tantivy that referenced this issue Dec 6, 2021
@saroh
canonicalize path when opening MmapDirectory
07c8c13 
fixes quickwit-oss#1229
saroh added a commit to saroh/tantivy that referenced this issue Dec 6, 2021
@saroh
canonicalize path when opening MmapDirectory
246edb0 
fixes quickwit-oss#1229
fulmicoton pushed a commit that referenced this issue Dec 9, 2021
@saroh
canonicalize path when opening MmapDirectory (#1231)
c980b19 
* canonicalize path when opening `MmapDirectory`
fixes #1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

canonicalize path when opening MmapDirectory saroh/tantivy
2 participants
@fmassot @fulmicoton