reliably queue MAX_DATA frames #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4844 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 149 149
Lines 16078 16087 +9
=======================================
+ Hits 13456 13464 +8
- Misses 2091 2092 +1
Partials 531 531 ☔ View full report in Codecov by Sentry. |
MarcoPolo
reviewed
Jan 10, 2025
| @@ -205,9 +207,13 @@ func (s *receiveStream) readImpl(p []byte) (bool, int, error) { | |||
| // when a RESET_STREAM was received, the flow controller was already | |||
| // informed about the final byteOffset for this stream | |||
| if !s.cancelledRemotely { | |||
| if queueMaxStreamData := s.flowController.AddBytesRead(protocol.ByteCount(m)); queueMaxStreamData { | |||
| hasStream, hasConn := s.flowController.AddBytesRead(protocol.ByteCount(m)) | |||
There was a problem hiding this comment.
nit: may as well assign these to your vars hasXWindowUpdate
There was a problem hiding this comment.
Depends on how the loop executes / returns. I think it should be fine, but I wanted to be very explicit about not setting value from true back to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure that a MAX_DATA frame actually triggers the packing of a new packet (with which it can then be sent out). Otherwise, reading from a stream might get the MAX_DATA frame queued, but if no packet is sent, it's never sent out to the peer, potentially leading to a deadlock of the connection.