-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geom): Add support for multi-geometries [OL5] #213
Conversation
4e3954e
to
587723f
Compare
@samuel-girard I fixed the linting problem on next branch, could you rebase please ? |
@samuel-girard I fixed the linting problem on next branch, could you rebase please ? |
17e11ca
to
0e4c4c3
Compare
0e4c4c3
to
84b7dd8
Compare
20086b9
to
ee186a8
Compare
84b7dd8
to
e774111
Compare
Hi all, I rebase this branch on next after merging OL5 PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems alright to me. I made some feedback on details.
The only breaking change is to finally use the coordinates entirely and therefore correctly 😄 :
<aol-collection-coordinates [coordinates]="f.geometry.coordinates[0]"></aol-collection-coordinates>
become :
<aol-collection-coordinates [coordinates]="f.geometry.coordinates"></aol-collection-coordinates>
projects/ngx-openlayers/src/lib/geom/geometrylinestring.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-openlayers/src/lib/geom/geometrymultipolygon.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-openlayers/src/lib/geom/geometrypoint.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-openlayers/src/lib/geom/geometrypolygon.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-openlayers/src/lib/geom/simplegeometry.component.ts
Outdated
Show resolved
Hide resolved
e774111
to
d66161a
Compare
d66161a
to
8d813c8
Compare
@kekel87 agree with changes? |
@Yakoust Yep i agree 👍 |
Hello,
This change brings support for multi-geometries.
The change is to be applied only after #183 is merged.
There is just one breaking change: the coordinates input on
CollectionCoordinatesComponent
is not anymore limited to type[number, number][]
, but it supports all types of coordinates.That means the existing code must be updated for polygons:
Old style:
New style:
Notice the
[coordinates]
input is now a[number, number][][]
, as defined in GeoJSON.This also allows to display polygon with holes, which is not possible with the current code.