rails/active job: Time casting fails

[siegy22]

Using rails 6.0.0.rc1 and pg 1.1.4:

• rails new foo && cd foo
• (Add que to Gemfile, set active_job.queue_adapter = :que generate migration, migrate database)
• rails g job example
• rails runner ExampleJob

Resulting in:

Loading development environment (Rails 6.0.0.rc1)
irb(main):001:0> ExampleJob.perform_later
Enqueued ExampleJob (Job ID: 96741bc2-47a8-4efc-b768-bfab1e4395e5) to Que(default)
Traceback (most recent call last):
        1: from (irb):1
TypeError (no implicit conversion of Time into String)

[siegy22]

My assumption is that pg (since whatever version) automatically does the casting.

The following patch fixes this.

@@ -152,7 +152,11 @@ module Que
       },
 
       # Timestamp with time zone
-      1184 => Time.method(:parse),
+      1184 => -> (value) {
+        return value if value.is_a?(Time)
+
+        Time.parse(value)
+      },
     }
 
     # JSON, JSONB

[chanks]

Fixed in master.

[9mm]

Is it possible to also fix this on 0.x branch? We use this in production and 1.0 wasnt stable enough, but it looks like it was only fixed on 1.0 beta

[danielpclark]

For those using one of the later versions of the 0.x releases with Rails you can create a file config/initializers/que.rb and place the following in it.

Que::Adapters::Base::CAST_PROCS[1184] = lambda do |value|
  case value
  when Time then value
  when String then Time.parse(value)
  else raise "Unexpected time class: #{value.class} (#{value.inspect})"
  end
end

This will patch the issue when upgrading to Rails 6.

[newbenji]

Is it possible to also fix this on 0.x branch? We use this in production and 1.0 wasnt stable enough, but it looks like it was only fixed on 1.0 beta

Anything about 1.0 is ready?
and what issue did you see with 1.0...

[siegy22]

@newbenji Check the 1.0 milestone: https://github.com/que-rb/que/milestone/1

[LukeClancy]

This breaks que-web as well by the way, and the fix doesn't work for it

Although I think the job itself still works... will update when it runs