Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cjson in favor of the python json module. #50

Merged
merged 1 commit into from
Jun 5, 2014

Conversation

ionrock
Copy link
Contributor

@ionrock ionrock commented Jun 4, 2014

Remove cjson in favor of the stdlib json module. This is essentially the same as #32, the difference being it is one commit. Tests are passing.

@ionrock
Copy link
Contributor Author

ionrock commented Jun 4, 2014

As an aside, this is preventing us from using the released version as we have servers that need this functionality that fail to compile cjson.

rohitagarwal003 added a commit that referenced this pull request Jun 5, 2014
Remove cjson in favor of the python json module.
@rohitagarwal003 rohitagarwal003 merged commit bca2100 into qubole:master Jun 5, 2014
@rohitagarwal003
Copy link
Contributor

Thanks @ionrock!

@ionrock
Copy link
Contributor Author

ionrock commented Jun 5, 2014

Thanks @mindprince! Would you mind pushing out a new release to pypi?

@ionrock ionrock deleted the remove-cjson branch June 5, 2014 14:02
@rohitagarwal003
Copy link
Contributor

Pushed a new release-candidate to PyPI.

@ionrock
Copy link
Contributor Author

ionrock commented Jun 6, 2014

Fantastic! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants