new: dev: ACM-6082: Support cluster notifications in sdk #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrygo
reviewed
Jul 14, 2020
qds_sdk/clusterv2.py
Outdated
| @@ -316,6 +318,8 @@ def set_cluster_info(self, | |||
|
|
|||
| `datadog_app_token` : Specify the Datadog APP token to use the Datadog monitoring service | |||
|
|
|||
| `notifications` : Specify the list of notification channels | |||
There was a problem hiding this comment.
should the parameter me notifications _channels instead?
tarrygo
reviewed
Jul 14, 2020
qds_sdk/clusterv2.py
Outdated
| type=int, | ||
| dest="notifications", | ||
| default=None, | ||
| help="List of notification channels", ) |
There was a problem hiding this comment.
List of notification channel ids
tarrygo
approved these changes
Jul 14, 2020
tarrygo
previously approved these changes
Jul 14, 2020
tarrygo
previously approved these changes
Jul 15, 2020
chattarajoy
approved these changes
Jul 17, 2020
chattarajoy
pushed a commit
that referenced
this pull request
Oct 6, 2020
Co-authored-by: Vasant M <vasantm@qubole.com> Co-authored-by: Joy Lal Chattaraj <8450903+chattarajoy@users.noreply.github.com> (cherry picked from commit ed05e0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.