Ability to set azure cluster composition #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattarajoy
previously approved these changes
Jun 15, 2020
| @@ -5,3 +5,9 @@ def create_parser(self, argparser): | |||
|
|
|||
| def set_cloud_config_from_arguments(self, arguments): | |||
| return NotImplemented | |||
|
|
|||
| def set_composition_arguments(self, comp_group): | |||
| pass | |||
There was a problem hiding this comment.
should we
Suggested change
| pass | |
| return NotImplemented |
?
There was a problem hiding this comment.
If we go with that approach, we have to check for cloud when we set the composition.
Rather than having an if condition to check whether the cloud supports, each cloud can set empty data or implement the function which will sets the value.
I implemented it this way to avoid that if conditions. In future, user has to implement the function and no need to edit the condition to allow cloud to set compositions.
Co-authored-by: Joy Lal Chattaraj <8450903+chattarajoy@users.noreply.github.com>
chattarajoy
previously approved these changes
Jun 17, 2020
|
LGTM overall, @harshshah87 please let me know if this is ready to merge |
akaranjkar-qu
previously approved these changes
Jun 18, 2020
61eb262
akaranjkar-qu
approved these changes
Jun 18, 2020
|
@chattarajoy : We can merge now. |
chattarajoy
approved these changes
Jun 19, 2020
chattarajoy
pushed a commit
that referenced
this pull request
Oct 6, 2020
(cherry picked from commit 96d16fd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.