Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-376: Reverting the refactoring of cluster_cmd_line as it is tightly coupled in test utils. #286

Merged
merged 28 commits into from
Nov 12, 2019
Merged

SDK-376: Reverting the refactoring of cluster_cmd_line as it is tightly coupled in test utils. #286

merged 28 commits into from
Nov 12, 2019

Conversation

tarrygo
Copy link
Contributor

@tarrygo tarrygo commented Oct 22, 2019

No description provided.

tarrygo and others added 28 commits September 30, 2019 12:38
@tarrygo
Merge pull request #1 from qubole/unreleased
4bc8308 
Unreleased
Cluster v2 changes
9ca11df
Adding changes
57e8e0f
bugfix
5cb125b
Changing the function definition of set_composition method
54cd739
Minor formatting changes
35e87fd
Fixing syntax errors
12e5989
minor errors
2f01c9b
formatting the file
17b583e
changes
bd80f9e
Adding master type
d8c27db
change
713091a
change
e7bcbfa
Changes for cluster composition
fc16621
Changes for cluster composition
e44416a
@tarrygo
Merge branch 'unreleased' into SDK-376
13ce035
Changes for tests
6f2f8be
Merge branch 'SDK-376' of https://github.com/tarrygo/qds-sdk-py into …
54aad7e 
…SDK-376
Changes for tests
614fc1f
@shekharsaurabh
SDK-375: Added support for Qubole-trace-Id (qubole#285)
819804a 
Added support for Qubole-trace-Id
Removing deepsource library
4a96c9c
Merge branch 'SDK-376' of https://github.com/tarrygo/qds-sdk-py into …
fba4cc0 
…SDK-376
Revert "Merge branch 'SDK-376' of https://github.com/tarrygo/qds-sdk-py…
b0face0 
… into SDK-376"

This reverts commit fba4cc0, reversing
changes made to 4a96c9c.
Adding testcases for all the cluster composition combination
1f0cf36
@tarrygo
Merge pull request #2 from qubole/unreleased
fb26197 
Merging latest unreleased
Merge branch 'unreleased' into SDK-376
469f96e
removing refactored cluster_info_factory and cluster_cmd_line due to …
6025072 
…tight integration with test utiuls
@tarrygo
Merge branch 'unreleased' into SDK-376
5ce5097
tarrygo
tarrygo commented Nov 12, 2019
View reviewed changes
Copy link
Contributor Author

@tarrygo tarrygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files cluster_cmd_line.py and cluster_info_factory has been merged in clusterv2.py as test utils has a direct dependency on it.

@chattarajoy chattarajoy merged commit ab247ba into qubole:unreleased Nov 12, 2019
chattarajoy pushed a commit that referenced this pull request Feb 18, 2020
@tarrygo @chattarajoy
SDK-376: Revert the refactoring of cluster_cmd_line (#286)
3937ba6 
Revert the refactoring of cluster_cmd_line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chattarajoy chattarajoy chattarajoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarrygo @chattarajoy @shekharsaurabh