Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sdk-376: Adding support for multiple API versions in clusters #284

Merged
merged 24 commits into from
Oct 17, 2019
Merged

Sdk-376: Adding support for multiple API versions in clusters #284

merged 24 commits into from
Oct 17, 2019

Conversation

tarrygo
Copy link
Contributor

@tarrygo tarrygo commented Sep 30, 2019 •
edited
Loading

  1. Adding support for v2.2 API version for clusters
  2. Adding cluster composition.

@tarrygo tarrygo changed the title Sdk-376: cluster v2 changes Sdk-376: Adding support for multiple API versions in clusters Oct 15, 2019
@tarrygo
Copy link
Contributor Author

tarrygo commented Oct 15, 2019

@akaranjkar-qu Can you please review this PR. I am in the process of writing testcases. In the meanwhile can you please review and approve it. We need to release it urgently for cluster composition testing.

akaranjkar-qu
akaranjkar-qu previously approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@akaranjkar-qu akaranjkar-qu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please remove the deepsource binary before merging

@tarrygo tarrygo requested a review from akaranjkar-qu October 15, 2019 18:46
akaranjkar-qu
akaranjkar-qu previously approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@akaranjkar-qu akaranjkar-qu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chattarajoy
chattarajoy approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@chattarajoy chattarajoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes, @tarrygo will run regressions using the unreleased branch before releasing a new version.

@chattarajoy chattarajoy merged commit 8231a42 into qubole:unreleased Oct 17, 2019
chattarajoy pushed a commit that referenced this pull request Feb 18, 2020
@tarrygo @chattarajoy
SDK-376: Adding support for multiple API versions in clusters (#284)
05f8994 
This adds Support for multiple API versions in clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaranjkar-qu akaranjkar-qu akaranjkar-qu approved these changes

@chattarajoy chattarajoy chattarajoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarrygo @chattarajoy @akaranjkar-qu @shekharsaurabh