Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating requests and urllib3 #280

Merged

Conversation

brickyard
Copy link
Contributor

Security scans are showing CRLF injection vulnerabilities in the older versions of requests and urllib3.

included unittests pass and manual spot testing of examples in the README.rst succeed.

@chattarajoy chattarajoy changed the base branch from master to unreleased July 31, 2019 05:33
@chattarajoy chattarajoy force-pushed the update-urllib-requests-versions branch from d255da4 to 85c9712 Compare July 31, 2019 05:34
@chattarajoy
Copy link
Member

thanks for the PR @brickyard. I have added a few other changes to fix the Travis CI and also move requests to 2.21.0 as it is the latest version supported on Python 3.4. I hope that would also resolve the security vulnerability.

@chattarajoy chattarajoy merged commit 7b40634 into qubole:unreleased Jul 31, 2019
chattarajoy pushed a commit that referenced this pull request Jul 31, 2019
This fixes security vulnerabilities in current versions of these packages.
chattarajoy added a commit to chattarajoy/qds-sdk-py that referenced this pull request Nov 4, 2019
harshashah16 pushed a commit to harshashah16/qds-sdk-py that referenced this pull request Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants