chg: dev: SDK-330: Add page and per-page option to Cluster and ClusterV2 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lusters by state for api version v1.3.
msumit
reviewed
Jan 24, 2019
| if per_page: | ||
| params['per_page'] = per_page | ||
| params = None if not params else params | ||
| cluster_list = conn.get(cls.rest_entity_path, params=params) |
There was a problem hiding this comment.
afaik clusters v1 does not support pagination
There was a problem hiding this comment.
Yes that's right. When using v1.2, it just returns all the clusters. Should I modify it to log a warning that v1.2 doesn't support pagination and will list all the clusters?
There was a problem hiding this comment.
yeah, that should be fine. Also, the code as of now looks like that its going to support pagination, which is not correct, hence remove all these changes.
|
As discussed, logged a warning when pagination options are provided with API v1.2 |
msumit
added a commit
that referenced
this pull request
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeError: string indices must be integers