Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated a fetcher for openSUSE and for SUSE Linux Enterprise #218

Closed

Conversation

jordimassaguerpla
Copy link
Contributor

We extracted oval parser from rhel and used that for opensuse and
SUSE Linux Enterpise

Signed-off-by: Thomas Boerger tboerger@suse.de
Signed-off-by: Jordi Massaguer Pla jmassaguerpla@suse.de

We extracted oval parser from rhel and used that for opensuse and
SUSE Linux Enterpise

Signed-off-by: Thomas Boerger <tboerger@suse.de>
Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.de>
@jordimassaguerpla jordimassaguerpla mentioned this pull request Jul 15, 2016
4 tasks
* upstream/master:
  updater: enable fetching of RHEL 5 vulnerabilities (quay#217)
  README: add reference to Klar tool
  improve v1 api docs header legibility
  godeps: Remove implicit git submodules
  readme: add various talks & slides
  readme: replace latest by v1.2.2 and add reference to container repositories
  travis: allow golang 'tip' failures (quay#202)
  updater: delete Ubuntu's repository upon bzr errors
  Modify URL of libpq documentation (quay#197)
if err != nil {
return resp, err
}
firstRHSA, err := strconv.Atoi(flagValue)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests pass but this thing of getting the firstRHSA from the flagValue ... not sure If I extracted this correctly or if I even understood what this was for .... Can someone else just take a look and see if I missed something here? Thanks and sorry I if did.

@jordimassaguerpla
Copy link
Contributor Author

The unit tests pass but I have not tested it manually. I will do it asap.

@jordimassaguerpla
Copy link
Contributor Author

I am testing opensuse with this docker image

https://gist.github.com/jordimassaguerpla/8ce11ed97284b4f4a5b40647b1730b7b

@jordimassaguerpla
Copy link
Contributor Author

I tried it with opensuse by starting clair and then running

./analyze-local-images -minimum-severity Unknown opensuse_vul

opensuse_vul is the opensuse docker image that contains at least one vulnerability (see previous comment).

The result is as expected, it outputs the expected vulnerability (and others), as long as you specify the severity "Unknown". That is something we are working on too.

@jordimassaguerpla
Copy link
Contributor Author

closing this in favor of #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant