httptransport: notification content type, etc #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4dcbf2 to
e2e8b52
Compare
crozzy
previously approved these changes
Jul 22, 2022
e2e8b52 to
ad23de1
Compare
This updates the notification endpoints to be more in-line with the new all-in-one, interally instrumented handler style. It also includes a change for making the instrumentation code less verbose. Closes: quay#1523 Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
This change switches to using the internal `apiError` function and uses the "embed" package instead of generated code. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
ad23de1 to
f34148a
Compare
|
clean rebase and tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated/fixed the notification handler, then updated the discovery endpoint for good measure.