Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment: use service prefix for simplified path routing #1043

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

ldelossa
Copy link
Contributor

This commit adds a service prefix to api paths. Prior to this commit
adding a new end point to ClairV4 would require operations to
reconfigure their infrastructure.

Signed-off-by: ldelossa ldelossa@redhat.com

This commit adds a service prefix to api paths. Prior to this commit
adding a new end point to ClairV4 would require operations to
reconfigure their infrastructure.

Signed-off-by: ldelossa <ldelossa@redhat.com>
@ldelossa
Copy link
Contributor Author

cc @alecmerdler - will need api changes in Quay.

Copy link
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not happy about this change, but it does make operators' configs much simpler.

@ldelossa
Copy link
Contributor Author

@hdonnay continue to brain storm on ways we can achieve both goals - nothing is set in stone just yet.

@ldelossa ldelossa merged commit bc4c324 into quay:development-4.0 Sep 22, 2020
@ldelossa ldelossa deleted the louis/api-prefixes branch January 27, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants