logging: add similar logging to v3 #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Add back in HTTP logging to what was present in v3, to each of the handlers. Signed-off-by: mcoops <cooper.d.mark@gmail.com>
Allda
reviewed
Sep 15, 2020
httptransport/logginghandler.go
Outdated
| Str("remote addr", r.RemoteAddr). | ||
| Str("method", r.Method). | ||
| Str("request uri", r.RequestURI). | ||
| Str("status", strconv.Itoa(http.StatusOK)). |
There was a problem hiding this comment.
Does this always log 200?
There was a problem hiding this comment.
That's embarrassing runs I hate how that works. Readding
Signed-off-by: mcoops <cooper.d.mark@gmail.com>
|
I assume we squash on merge? Otherwise can rebase. |
ldelossa
suggested changes
Sep 15, 2020
Signed-off-by: mcoops <cooper.d.mark@gmail.com>
ldelossa
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back in HTTP logging to what was present in v3, to each of the handlers.
Matched the existing format/fields from v3 here:
clair/api/v3/server.go
Line 62 in 1d14177
Didn't add tests as there isn't really much to test.