feat(docs&api&ts): Add new top-level section 'fields' #14243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlCallo
reviewed
Sep 5, 2022
| @@ -152,5 +152,53 @@ | |||
| } | |||
| } | |||
| } | |||
| }, | |||
|
|
|||
| "fields": { | |||
There was a problem hiding this comment.
If we don't merge in #14241 as I suggested to avoid, these definitions need to be moved into scoped slots params
|
Excellent work @yusufkandemir ! |
rstoenescu
added a commit
that referenced
this pull request
Sep 14, 2022
rstoenescu
added a commit
that referenced
this pull request
Sep 14, 2022
…on the "describe" command #14243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)Other information:
Closes #11510, #13217
Depends on #14241 because QUploader isn't exposing the fields.
This adds a top-level property called "fields" to our JSON API system. I analyzed all components that have public instance fields and added JSON API content for them. The docs API cards now have a section called "fields" at the end if applicable. We are also generating the types for fields in the instance type interfaces, e.g.
QUploader