Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Fontawesome and Ion icons not displayed #5

Closed
apasov opened this issue Jul 19, 2019 · 4 comments · Fixed by #12
Closed

Some Fontawesome and Ion icons not displayed #5

apasov opened this issue Jul 19, 2019 · 4 comments · Fixed by #12

Comments

@apasov
Copy link
Contributor

apasov commented Jul 19, 2019

Thank you for this great extension!
There are problems with some of the icons.
Fontawesome:
image

Ion:
image
@hawkeye64
Copy link
Member

Thanks for the info. I'll investigate and see what might be causing the issue .

@hawkeye64
Copy link
Member

Here's what I have:
image
As you can see, the fonts are showing up for me.
From your screenshots, are they from the demo site, or did you fork the branch?

@apasov
Copy link
Contributor Author

apasov commented Aug 21, 2019

The screenshots are from the demo site. Also I use this extension in a project of my own with the same result - some icons are absent. I test in latest Firefox and Chrome on Windows
image

Hope it helps.

@hawkeye64
Copy link
Member

Fixed in v1.0.2
I have hand-currated all the fonts with issues. Let me know if you find any more.

apasov added a commit to apasov/app-extension-qiconpicker that referenced this issue Aug 30, 2019
@apasov
fix: use fab prefix instead of fas for some fontawesome brand icons
7d56d5a 
Fixes quasarframework#5
@apasov apasov mentioned this issue Aug 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use fab prefix instead of fas for some fontawesome brand icons apasov/app-extension-qiconpicker
2 participants
@hawkeye64 @apasov