Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cypress): support component testing #185

Merged
merged 38 commits into from
Nov 26, 2021

Conversation

Evertvdw
Copy link
Contributor

@Evertvdw Evertvdw commented Oct 9, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • New test runner
  • Documentation
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Add Cypress component testing to E2E package

If you are adding a new test runner, have you...? (check all)

  • Created an issue first?
  • Registered it in /packages/base/runners.json?
  • Added it to /README.md?
  • Included one test that runs baseline.spec.vue?
  • Added and updated documentation?
  • Included a recipe folder with properly building quasar project?

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on Windows
  • It's been tested on Linux
  • It's been tested on MacOS
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Copy link
Member

@IlCallo IlCallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to check all the changes, but left some comments already, I'll need to play a bit with it to understand what's going on with the build and linting problems you got

@quasarframework quasarframework deleted a comment from netlify bot Oct 18, 2021
@IlCallo IlCallo changed the title Cypress component testing added to e2e-cypress package feat(cypress): support component testing Nov 26, 2021
@IlCallo IlCallo merged commit 9e1dc74 into quasarframework:next Nov 26, 2021
@IlCallo IlCallo deleted the cypress-component-testing branch November 26, 2021 16:34
IlCallo added a commit that referenced this pull request Feb 16, 2022
Co-authored-by: Paolo Caleffi <p.caleffi@dreamonkey.com>
IlCallo added a commit that referenced this pull request Feb 16, 2022
Co-authored-by: Paolo Caleffi <p.caleffi@dreamonkey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants