-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for maximum values in quarkus.http.limits #46428
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
94bb82c
to
ab091ba
Compare
…ChunkSize, maxFormAttributeSize, maxFormBufferedBytes
I agree it's a nice addition. I pushed it to CI to check everything is fine. |
Status for workflow
|
🎊 PR Preview 2ca87c3 has been successfully built and deployed to https://quarkus-pr-main-46428-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
And merged, thanks! |
This PR adds some small enhancements to the docs in
io.quarkus.vertx.http.runtime.ServerLimitsConfig
, stating the respective maximum values forio.quarkus.vertx.http.runtime.options.HttpServerOptionsUtils#applyCommonOptions
does many things, amongst others it forwards these settings to Vert.x APIs that expect anint
or along
, e.g.httpServerOptions.setMaxHeaderSize(httpConfig.limits().maxHeaderSize().asBigInteger().intValueExact());
.Sticking to that call, if
quarkus.http.limits.max-header-size
is set to2g
, that would lead to anjava.lang.ArithmeticException: BigInteger out of int range
(quite unlucky, but still:2g
or 2147483648 >Integer.MAX_VALUE
or 2147483647).BTW: I could imagine that this would cause an error elsewhere, but at least these Vert.x APIs would also accept
-1
to allow unlimited length, which is not possible to specify withio.quarkus.runtime.configuration.MemorySize
as perMEMORY_SIZE_PATTERN
. Also, we cannot not-define them due to@WithDefault
values inio.quarkus.vertx.http.runtime.ServerLimitsConfig
(which I think are great in there).