Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always close OutputStream in RESTEasy Classic #46419

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Always close OutputStream in RESTEasy Classic #46419

merged 1 commit into from
Feb 21, 2025
+11 −1

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 21, 2025

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 21, 2025
gsmet
gsmet requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not merge it right away, there's a problem on CI still.

@geoand
Copy link
Contributor Author

geoand commented Feb 21, 2025

You mean specific to this PR or a general problem?

@gsmet
Copy link
Member

gsmet commented Feb 21, 2025

A general issue with ITs not being properly run: I added a fix on top of Holly's workaround here: #46420 and rebased. I will check CI a bit later.

@geoand
Copy link
Contributor Author

geoand commented Feb 21, 2025

👌

@geoand geoand requested a review from gsmet February 21, 2025 13:28
gsmet
gsmet approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ITs are running now so we should be good if CI is fine.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 21, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 80b8eb4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 18e45f0 into quarkusio:main Feb 21, 2025
55 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 21, 2025
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 21, 2025
@gastaldi gastaldi deleted the resteasy-os branch February 21, 2025 20:00
@gsmet gsmet modified the milestones: 3.21 - main, 3.19.1 Feb 24, 2025
@jmartisk jmartisk modified the milestones: 3.19.1, 3.15.4 Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/resteasy-classic kind/bugfix triage/backport-3.8 triage/flaky-test
Projects
None yet
Milestone
3.15.4
Development

Successfully merging this pull request may close these issues.

Memory Leak in Quarkus REST Service if request failed with timeout.
3 participants
@geoand @gsmet @jmartisk