javax.net.ssl TLS configuration does not work in native mode

[ppalaga]

• Fixes: javax.net.ssl TLS configuration does not work in native mode #46368

[quarkus-bot]

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

• title should preferably start with an uppercase character (if it makes sense!)

_{This message is automatically generated by a bot.}

[github-actions]

🎊 PR Preview 675e2be has been successfully built and deployed to https://quarkus-pr-main-46379-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

[ppalaga]

I am working on a fix for the failing tests

[ppalaga]

ababb2f:

• Simplified the fix
• Added an integration test to cover also the native mode

[ppalaga]

@gsmet are there any plans for 3.19.1 by any chance? If not, I'll have to workaround this in Quarkus CXF.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ababb2f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ababb2f.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	JVM Integration Tests - JDK 17	Build	Failures	Logs	Raw logs	🔍
✖	JVM Integration Tests - JDK 17 Windows	Build	Failures	Logs	Raw logs	🔍
✖	JVM Integration Tests - JDK 21	Build	Failures	Logs	Raw logs	🔍

You can consult the Develocity build scans.

Failures

⚙️ JVM Integration Tests - JDK 17 #

- Failing: integration-tests/istio/maven-invoker-way 

📦 integration-tests/istio/maven-invoker-way

✖ Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.9.0:run (integration-tests) on project quarkus-integration-test-istio-invoker: 1 build failed. See console output above for details.

---

⚙️ JVM Integration Tests - JDK 17 Windows #

- Failing: integration-tests/istio/maven-invoker-way 

📦 integration-tests/istio/maven-invoker-way

✖ Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.9.0:run (integration-tests) on project quarkus-integration-test-istio-invoker: 1 build failed. See console output above for details.

---

⚙️ JVM Integration Tests - JDK 21 #

- Failing: integration-tests/istio/maven-invoker-way 

📦 integration-tests/istio/maven-invoker-way

✖ Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.9.0:run (integration-tests) on project quarkus-integration-test-istio-invoker: 1 build failed. See console output above for details.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/infinispan-cache/deployment

✖ io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

• expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)

---

⚙️ Maven Tests - JDK 17

📦 integration-tests/devmode

✖ io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService - History

• Too many recursions, message not returned for id [768361861] - java.lang.RuntimeException

java.lang.RuntimeException: Too many recursions, message not returned for id [768361861]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:164)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)

• Too many recursions, message not returned for id [79685496] - java.lang.RuntimeException

java.lang.RuntimeException: Too many recursions, message not returned for id [79685496]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:164)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)

[cescoffier]

LGTM

[cescoffier]

I'm a bit surprised by some of the test failures. Can you check if they are related?

[ppalaga]

I'm a bit surprised by some of the test failures. Can you check if they are related?

Let me have a look.

[ppalaga]

For the failures in quarkus-integration-test-istio-invoker, I think the problem was caused by some of the recent commits that attempted to optimize the CI, most probably this change:

5d351c8#diff-d8e36253822cffbdf21e333bcba467345b46e6095927dda98399fe7f21f4679aL437-R450

Hard to say for me what the correct state should be. @gsmet and @holly-cummins may know more.
I guess, either quarkus-integration-test-istio-invoker should not be invoked at all as a part of this job (because there is a separate workflow ci-istio.yml for that or the arguments for the job should be different: either e2e-tests sysprop should be false or not set (to skip the tests in the module) or some of [kubernetes|openshift|knative]-e2e-tests should be true so that kubernetes-client-api-server-url gets set.

Anyway I am quite sure those failures are unrelated to the current PR.

The tests flagged as flaky by Develocity, that failed on previous runs, seem to be passing now. I unfortunately do not remember which ones they were and therefore I cannot check whether they are impacted by the current change.