Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: document and use OidcTestClient to get access token from Dev Services for OIDC #45628

Conversation

michalvavrik
Copy link
Member

I realized when working on other PR that tests I added for Dev Services for OIDC should use OidcTestClient to get bearer access token. I also added docs for someone else to mention it as well. Docs addition is not important, I can drop the docs if you deem it useless.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jan 16, 2025

This comment has been minimized.

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/use-oidctestclient-with-dev-svc-for-oidc branch from 29e5d64 to e227b9c Compare January 16, 2025 12:52
@sberyozkin sberyozkin added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Jan 16, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit e227b9c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jan 16, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e227b9c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit c59377e into quarkusio:main Jan 16, 2025
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 16, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 16, 2025
@michalvavrik michalvavrik deleted the feature/use-oidctestclient-with-dev-svc-for-oidc branch January 16, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation triage/backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants