Improvements to the Grafana LGTM dashboards I #45620
Conversation
| @@ -51,7 +50,7 @@ protected byte[] getResourceAsBytes(String resource) { | |||
|
|
|||
| @SuppressWarnings("OctalInteger") | |||
| protected void addFileToContainer(byte[] content, String pathInContainer) { | |||
| log.infof("Content [%s]: \n%s", pathInContainer, new String(content, StandardCharsets.UTF_8)); | |||
| // log.infof("Content [%s]: \n%s", pathInContainer, new String(content, StandardCharsets.UTF_8)); | |||
There was a problem hiding this comment.
Ah cool, I found that quite annoying.
There was a problem hiding this comment.
What about some more condensed view ... e.g. first few lines.
So that the user knows something got added ...
There was a problem hiding this comment.
If the user cannot do anything with that info, I would remove it altogether or set it to debug.
There was a problem hiding this comment.
I've set it to debug
| @@ -82,7 +119,7 @@ private String getPrometheusConfig() { | |||
| Config runtimeConfig = ConfigProvider.getConfig(); | |||
| String rootPath = runtimeConfig.getOptionalValue("quarkus.management.root-path", String.class).orElse("/q"); | |||
| String metricsPath = runtimeConfig.getOptionalValue("quarkus.management.metrics.path", String.class).orElse("/metrics"); | |||
| int httpPort = runtimeConfig.getOptionalValue("quarkus.http.port", Integer.class).orElse(0); | |||
| int httpPort = runtimeConfig.getOptionalValue("quarkus.http.port", Integer.class).orElse(8080); // when not set use default | |||
There was a problem hiding this comment.
Doesn't the 0 do that -- helps set the default?
There was a problem hiding this comment.
The problem is that 0 is the default and should mean some random port, however, in devmode, the default port is 8080.
Unless the property is set by the user, the port ended up being set to 0 in the scraper, leading to no data collection. An insidious bug.
This comment has been minimized.
This comment has been minimized.
37791ed to
9acf79d
Compare
Status for workflow
|
|
@gsmet we decided to split the work into different PRs. |
Partial fix for: #43599
More PRs on the way.