Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load JDBC drivers through the service loader without using them #45540

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Don't load JDBC drivers through the service loader without using them #45540

merged 1 commit into from
Jan 13, 2025

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Jan 13, 2025 •
edited
Loading

This was introduced in #7089, which was specifically about a bug when using opentracing, which no longer has an extension in core,
and even its Quarkiverse extension is no longer maintained: https://github.com/quarkiverse/quarkus-smallrye-opentracing
The bug was also specific to Java 8.

The service loading is also causing problems with #41995

So, let's not do it at all, assuming tests passes.

@yrodiere yrodiere mentioned this pull request Jan 13, 2025
Closed
@yrodiere yrodiere force-pushed the agroal-no-driver-service-loading branch from c1c6879 to e4df4ae Compare January 13, 2025 15:13
@yrodiere
Don't load JDBC drivers through the service loader without using them
0262be6 
This was introduced in quarkusio#7089,
which was specifically about a bug when using opentracing,
which no longer has an extension in core,
and even its Quarkiverse extension is no longer maintained:
https://github.com/quarkiverse/quarkus-smallrye-opentracing
The bug was also specific to Java 8.

The service loading is also causing problems with quarkusio#41995

So, let's not do it all, assuming tests passes.
@yrodiere yrodiere force-pushed the agroal-no-driver-service-loading branch from e4df4ae to 0262be6 Compare January 13, 2025 15:14
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 13, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0262be6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ Maven Tests - JDK 17

📦 integration-tests/devmode

✖ io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService - History

  • Too many recursions, message not returned for id [1404708425] - java.lang.RuntimeException
java.lang.RuntimeException: Too many recursions, message not returned for id [1404708425]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:164)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
  • Too many recursions, message not returned for id [552982293] - java.lang.RuntimeException
java.lang.RuntimeException: Too many recursions, message not returned for id [552982293]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:164)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)

gsmet
gsmet approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in and we will wait for feedback from the field.

@gsmet gsmet merged commit f2d0581 into quarkusio:main Jan 13, 2025
43 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/agroal triage/flaky-test
Projects
None yet
Milestone
3.18.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@yrodiere @gsmet @geoand