Do not use grep -q when calculating the matrix #45437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grep -q exits as soon as it matches which can cause broken pipes if echo is not finished with the output. It should hopefully fix the issues with calculating the matrix in Ubuntu 24 (no idea why the Ubuntu 24 runners are more sensitive...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grep -q exits as soon as it matches which can cause broken pipes if echo is not finished with the output.
It should hopefully fix the issues with calculating the matrix in Ubuntu 24 (no idea why the Ubuntu 24 runners are more sensitive...).
@holly-cummins this should be the actual fix for the matrix calculation issue in Ubuntu 24. I'm not exactly sure why we got lucky when testing my previous fix. My intuition is that maybe the Ubuntu 24 runner are a bit faster and can cause these issues sporadically (but when I tested last time, it was always reproducible so unsure...).