Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop @ConfigMapping security interface with BUILD_AND_RUN_TIME_FIXED as we don't need denyUnannotated in the runtime config phase #45366

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jan 4, 2025

We don't use it during the runtime, can't think of other extension that would use it either. Let's drop it and have one less interface in the runtime package.

@michalvavrik michalvavrik changed the title Drop @ConfigMapping security interace with BUILD_AND_RUN_TIME_FIXED as we don't need denyUnannotated in the runtime config phase Drop @ConfigMapping security interface with BUILD_AND_RUN_TIME_FIXED as we don't need denyUnannotated in the runtime config phase Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

🎊 PR Preview 9512889 has been successfully built and deployed to https://quarkus-pr-main-45366-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

This comment has been minimized.

@michalvavrik michalvavrik requested a review from gastaldi January 4, 2025 19:27
@michalvavrik
Copy link
Member Author

@sberyozkin is off for a week and this is puny refactoring so I requested @gastaldi . Hope is fine.

@michalvavrik michalvavrik force-pushed the feature/move-deny-unannotated-to-buildtime-fixed branch from 2204401 to 1d5b794 Compare January 4, 2025 23:13
@michalvavrik michalvavrik requested a review from gastaldi January 4, 2025 23:14
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 4, 2025
Copy link

quarkus-bot bot commented Jan 4, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 1d5b794.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jan 5, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1d5b794.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit 0e9d883 into quarkusio:main Jan 5, 2025
34 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 5, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 5, 2025
@michalvavrik michalvavrik deleted the feature/move-deny-unannotated-to-buildtime-fixed branch January 5, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants