Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor: Move TestBuildChainFunction to its own class #44867

Merged

Conversation

holly-cummins
Copy link
Contributor

This is a minor refactoring to support https://github.com/orgs/quarkusio/projects/30. It will make the diff smaller on WG 30, but it’s also (ever-so-slightly) valuable in its own right.

This change moves a static inner class out to be its own class. At the moment, we have a superclass referencing an inner class of a descendant class, which is ugly. The descendant class is 1300 lines long, so making it a bit smaller is a bonus. :)

This comment has been minimized.

@holly-cummins holly-cummins force-pushed the refactor-testbuildchainfunction branch from 9ad4e90 to 450fd34 Compare December 2, 2024 10:48
Copy link

quarkus-bot bot commented Dec 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 450fd34.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Native Tests - Security2

📦 integration-tests/oidc-code-flow

io.quarkus.it.keycloak.CodeFlowInGraalITCase.testTokenRefresh - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at io.quarkus.it.keycloak.CodeFlowTest$3.call(CodeFlowTest.java:733)
	at io.quarkus.it.keycloak.CodeFlowTest$3.call(CodeFlowTest.java:720)
	at org.awaitility.core.CallableCondition$ConditionEvaluationWrapper.eval(CallableCondition.java:99)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)

@holly-cummins
Copy link
Contributor Author

Thanks for the review, @geoand! I was going to ask you but you beat me to it :)

@geoand
Copy link
Contributor

geoand commented Dec 2, 2024

:)

@geoand geoand merged commit 98ddff2 into quarkusio:main Dec 2, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants