Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More appropriate test application module initialization in QuarkusDevModeTest #44825

Merged

Conversation

aloubyansky
Copy link
Member

This fixes warnings running QuarkusDevModeTests, such as

[INFO] Running io.quarkus.devui.BuildMetricsTest
2024-11-28 23:51:03,005 WARN  [io.qua.boo.BootstrapAppModelFactory] (main) Expected project directory /home/aloubyansky/git/quarkus/extensions/vertx-http/deployment/target/quarkus-dev-mode-test18265132251066872043 does not match current project directory /home/aloubyansky/git/quarkus/extensions/vertx-http/deployment

by making sure the correct test application module is returned from ApplicationModel.getAppArtifact().

This should also fix issues reported in the comments of #44104

This comment has been minimized.

This comment has been minimized.

@aloubyansky
Copy link
Member Author

The failures look related I'll have a look

@aloubyansky aloubyansky force-pushed the dev-mode-test-proper-app-module branch from 074f1b2 to 12f3d88 Compare November 29, 2024 20:28

This comment has been minimized.

@aloubyansky
Copy link
Member Author

These failures aren't related. None of the failing tests is a QuarkusDevModeTest.

The issue with the previous failure was related to using a made up artifact ID for a test project. Now that the original (test containing module) artifact ID is used, the previous failure is fixed.

@aloubyansky
Copy link
Member Author

aloubyansky commented Nov 30, 2024

I'll re-run the CI, just in case.

@aloubyansky aloubyansky force-pushed the dev-mode-test-proper-app-module branch from 12f3d88 to 9b4f338 Compare November 30, 2024 05:12
@geoand
Copy link
Contributor

geoand commented Nov 30, 2024

💪

Copy link

quarkus-bot bot commented Nov 30, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9b4f338.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/websockets-next/deployment

io.quarkus.websockets.next.test.telemetry.MicrometerWebSocketsOnBinaryMessageTest.testClientEndpoint_MultiTextReceived_MultiTextSent - History

  • Assertion condition defined as a Lambda expression in io.quarkus.websockets.next.test.telemetry.MetricsAsserter 1 expectation failed. Response body doesn't match expectation. Expected: Key 'quarkus_websockets_server_connections_opened_total' with value '21' and direction 'null' Actual: \# TYPE jvm_threads_peak_threads gauge \# HELP jvm_threads_peak_threads The peak live thread count since the Java virtual machine started or peak was reset - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.websockets.next.test.telemetry.MetricsAsserter 1 expectation failed.
Response body doesn't match expectation.
Expected: Key 'quarkus_websockets_server_connections_opened_total' with value '21' and direction 'null'
  Actual: # TYPE jvm_threads_peak_threads gauge
# HELP jvm_threads_peak_threads The peak live thread count since the Java virtual machine started or peak was reset
jvm_threads_peak_threads 92.0
# TYPE jvm_memory_committed_bytes gauge

io.quarkus.websockets.next.test.telemetry.MicrometerWebSocketsOnBinaryMessageTest.testServerEndpoint_broadcasting - History

  • Assertion condition defined as a Lambda expression in io.quarkus.websockets.next.test.telemetry.AbstractWebSocketsOnMessageTest Expected 1, got 0 ==> expected: <true> but was: <false> within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.websockets.next.test.telemetry.AbstractWebSocketsOnMessageTest Expected 1, got 0 ==> expected: <true> but was: <false> within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.websockets.next.test.telemetry.AbstractWebSocketsOnMessageTest.testServerEndpoint_broadcasting(AbstractWebSocketsOnMessageTest.java:414)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@aloubyansky aloubyansky merged commit 2704a77 into quarkusio:main Nov 30, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants