-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More appropriate test application module initialization in QuarkusDevModeTest #44825
More appropriate test application module initialization in QuarkusDevModeTest #44825
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The failures look related I'll have a look |
074f1b2
to
12f3d88
Compare
This comment has been minimized.
This comment has been minimized.
These failures aren't related. None of the failing tests is a QuarkusDevModeTest. The issue with the previous failure was related to using a made up artifact ID for a test project. Now that the original (test containing module) artifact ID is used, the previous failure is fixed. |
I'll re-run the CI, just in case. |
12f3d88
to
9b4f338
Compare
💪 |
Status for workflow
|
This fixes warnings running
QuarkusDevModeTest
s, such asby making sure the correct test application module is returned from
ApplicationModel.getAppArtifact()
.This should also fix issues reported in the comments of #44104