Logging and Datasource docstyle review #44799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
reviewed
Nov 28, 2024
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
9b166e8 to
b971083
Compare
This comment has been minimized.
This comment has been minimized.
maxandersen
reviewed
Nov 28, 2024
Signed-off-by: Michal Maléř <mmaler@redhat.com>
b971083 to
262a5e1
Compare
|
@maxandersen Thank you, Max. Applied. |
Status for workflow
|
jmartisk
approved these changes
Nov 29, 2024
yrodiere
approved these changes
Dec 2, 2024
|
This is not backportable to 3.15 as things have drifted a lot since 3.15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing a review to Logging and Datasource guides.
Little tweaks to grammar and style; removing false information.