Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split package issue in Kubernetes Service Binding extension #44751

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Nov 26, 2024

Copy link

quarkus-bot bot commented Nov 26, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7f175a6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link

🎊 PR Preview 0ad3119 has been successfully built and deployed to https://quarkus-pr-main-44751-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Nov 26, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7f175a6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand requested a review from iocanel November 27, 2024 07:38
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you decide if you want to merge or wait for @iocanel :)

@gsmet
Copy link
Member

gsmet commented Nov 27, 2024

@metacosm also will these changes affect you?

For the context, we are trying to solve several issues of split packages across the codebase.

@geoand
Copy link
Contributor Author

geoand commented Nov 28, 2024

I am almost certain that no one uses this extension outside of core, so I'll go ahead and merge it

@geoand geoand merged commit be0030f into quarkusio:main Nov 28, 2024
24 checks passed
@geoand geoand deleted the #44732 branch November 28, 2024 07:50
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io.quarkus.kubernetes.service.binding.runtime is split across deployment and runtime modules
2 participants