Add OIDC Client config builder

[michalvavrik]

• part of the Migrate OIDC-based extensions from config classes to @ConfigMapping #39185
• introduce new OIDC Client config builder and deprecate former config class
• is backwards compatible - users can keep using old OidcClientConfig as now the class implements the configmapping group interface, so users can still do oidcClients.newClient(formerConfigClass) while we migrated to the config mapping; that should reduce copying between config mapping interfaces and config classes
• improves generated docs as number of config properties is reduced (we show both named and unnamed client in one row, which is what was already done for the OIDC extension here Improve the way OIDC tenants are grouped and their properties are generated #44374)
• because we cannot modify interfaces impl. returned by SmallRye Config, I added config builder that makes sure that id is set if user didn't specify it explicitly. In past, we set this config class property inside of the recorder, but now it needs to be set bit sooner; situation shouldn't change for users though

[github-actions]

🙈 The PR is closed and the preview is expired.

[michalvavrik]

I mentioned I made mistake in one test so it didn't test what I wanted. I'll push in a minute. UPDATE: done

[sberyozkin]

Hi @michalvavrik, thanks, as far as the builder is concerned, did you follow the same pattern you did for the OIDC dynamic client config, where the whole OIDC client can be built with a single sequence, with sub-config-mappings having their own builders, which can be used independently and then plugged into into the main sequence or used inside that sequence with .end() ?

[sberyozkin]

Hi @michalvavrik, thanks, as far as the builder is concerned, did you follow the same pattern you did for the OIDC dynamic client config, where the whole OIDC client can be built with a single sequence, with sub-config-mappings having their own builders, which can be used independently and then plugged into into the main sequence or used inside that sequence with .end() ?

Looks like it is the case, sound good

[michalvavrik]

Hi @michalvavrik, thanks, as far as the builder is concerned, did you follow the same pattern you did for the OIDC dynamic client config, where the whole OIDC client can be built with a single sequence, with sub-config-mappings having their own builders, which can be used independently and then plugged into into the main sequence or used inside that sequence with .end() ?

Looks like it is the case, sound good

Yes, I believe so. And I added many shortcuts, but these things are quite opinionated, please let me know if you want another methods added to the builder. Thanks

[sberyozkin]

@michalvavrik As far as shortcuts are concerned, we can add them more if we notice users have to type some sub-optimal code, the important thing is that they have options how to structure the complete build sequence, without having a single flat builder to set everything

[michalvavrik]

@michalvavrik As far as shortcuts are concerned, we can add them more if we notice users have to type some sub-optimal code, the important thing is that they have options how to structure the complete build sequence, without having a single flat builder to set everything

I am just working on it. Will push it soon.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 5a51c3a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5a51c3a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[michalvavrik]

btw I have checked https://quarkus-pr-main-44697-preview.surge.sh/version/main/guides/all-config with "quarkus.oidc-client." and it looks fine (javadoc there).

[sberyozkin]

Thanks @michalvavrik, all is ready for the last one :-), thanks very much

[michalvavrik]

Thanks @michalvavrik, all is ready for the last one :-), thanks very much

that's already WIP, looking forward to finishing it in a day or two. until then!