-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incubating Maven resolver: do not load the workspace when the original resolver isn't aware of it #44680
Incubating Maven resolver: do not load the workspace when the original resolver isn't aware of it #44680
Conversation
…l resolver isn't aware of it, switch to choose between blocking and non-blocking dependency processor, clean-up
|
||
private static final Logger log = Logger.getLogger(NonBlockingModelResolutionTaskRunner.class); | ||
|
||
private final Phaser phaser = new Phaser(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man, I've almost never seen a Phaser
used :)
import org.jboss.logging.Logger; | ||
|
||
/** | ||
* Non-blocking task runner implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it also makes sense to document when it makes sense to use this implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, if the non-blocking failed, to check whether it due to concurrency issues :)
So that plus to see how much more efficient the non-blocking approach is.
I'll document it when I make it a proper option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Status for workflow
|
This change includes an important enhancement in the incubating application model resolver impl to skip workspace loading when it's not necessary.
It also introduces an option to switch to a blocking task runner in the incubating resolver (for now not documented, for my own testing, I'll make it a proper option later) and some other clean up.