-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not-found links when management enabled #44675
Conversation
This comment has been minimized.
This comment has been minimized.
Isn't it a bit confusing that we don't display the whole host:port when it's not the same as the current URL? |
8725b9c
to
fbfb023
Compare
@gsmet ok I have changed it to show the full path. This is also more in line with the Endpoints page in Dev UI: |
fbfb023
to
2c2edda
Compare
This comment has been minimized.
This comment has been minimized.
@phillip-kruger last question: how are they sorted? It looks very random with Health stuff being mixed with other stuff? |
2c2edda
to
dc7ac15
Compare
@gsmet It is ordered based on the distance from root (or in other words, the number of / in the url). I have change this to be alphabetic by default, and added a button to toggle between alphabetic and distance from root. |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
dc7ac15
to
9c5adf7
Compare
Status for workflow
|
OK, not entirely sure about the necessity of being able to sort by distance but I suppose it won't hurt :). Nice improvements! Also now, by default, standard and management interfaces will be on the same host so order will make more sense (we won't have management first). |
Fix #44639