Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not-found links when management enabled #44675

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

phillip-kruger
Copy link
Member

Fix #44639

Peek 2024-11-25 11-06

@phillip-kruger phillip-kruger requested a review from gsmet November 25, 2024 00:15

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Nov 25, 2024

Isn't it a bit confusing that we don't display the whole host:port when it's not the same as the current URL?

@phillip-kruger
Copy link
Member Author

@gsmet ok I have changed it to show the full path. This is also more in line with the Endpoints page in Dev UI:

image

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Nov 26, 2024

@phillip-kruger last question: how are they sorted? It looks very random with Health stuff being mixed with other stuff?

@phillip-kruger
Copy link
Member Author

@gsmet It is ordered based on the distance from root (or in other words, the number of / in the url). I have change this to be alphabetic by default, and added a button to toggle between alphabetic and distance from root.

Peek 2024-11-25 11-06

This comment has been minimized.

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
Copy link

quarkus-bot bot commented Nov 27, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9c5adf7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit e5ab20f into quarkusio:main Nov 27, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 27, 2024
@gsmet
Copy link
Member

gsmet commented Nov 27, 2024

OK, not entirely sure about the necessity of being able to sort by distance but I suppose it won't hurt :).

Nice improvements!

Also now, by default, standard and management interfaces will be on the same host so order will make more sense (we won't have management first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using the management interface, URLs for management pages in Dev UI are incorrect
2 participants