Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend websocket next documentation to explain when and when not to subscribe to a Uni or Multi #44556

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Extend websocket next documentation to explain when and when not to subscribe to a Uni or Multi #44556

merged 1 commit into from
Nov 20, 2024

Conversation

cescoffier
Copy link
Member

Fix #42566

@cescoffier cescoffier requested a review from mkouba November 18, 2024 08:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@cescoffier cescoffier force-pushed the websocket-next-subscription branch from 829a2ac to 60c79b6 Compare November 19, 2024 13:13
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
mkouba
mkouba reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

docs/src/main/asciidoc/websockets-next-reference.adoc Outdated Show resolved Hide resolved
@cescoffier cescoffier force-pushed the websocket-next-subscription branch from 60c79b6 to 03a5ea7 Compare November 20, 2024 06:42
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 20, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 03a5ea7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@mkouba mkouba merged commit 26db59d into quarkusio:main Nov 20, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 20, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Nov 20, 2024
@cescoffier cescoffier deleted the websocket-next-subscription branch November 22, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement New feature or request
Projects
None yet
Milestone
3.18.0.CR1
Development

Successfully merging this pull request may close these issues.

be explicit/use examples in websocket.next docs when it comes to subscribe call for action
2 participants
@cescoffier @mkouba