Fixing the badly ended conditionals

[MichalMaler]

Previously, I created conditionals that were not properly ended.
This fix is maybe a solution for the troubles caused during the downstreaming of this guide.
Ref:

• Adding a datasource attribute and conditionalization #44252
• [3.15] (Do not merge)testing the proper use of the {includes} attribute when including a snippet #44223

[rsvoboda]

For the future, @MichalMaler is there a way to validate adocs by a tool to prevent issues like this?

[github-actions]

🎊 PR Preview 4968e01 has been successfully built and deployed to https://quarkus-pr-main-44294-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

[MichalMaler]

For the future, @MichalMaler is there a way to validate adocs by a tool to prevent issues like this?

We don't have such a tool right now, but I agree it would be great to have something that can check if all conditions are properly enclosed.
It was a silly mistake by me, but on the other hand, that's why we have reviews.

[rsvoboda]

It was a silly mistake by me, but on the other hand, that's why we have reviews.

With a load of pull requests landing to the Quarkus repo, I don't think it's a reasonable expectation. Creator/Owner of the PR is the primary responsible person and that's also why having a tool that would help identify incorrect syntax would help.

[MichalMaler]

It was a silly mistake by me, but on the other hand, that's why we have reviews.

With a load of pull requests landing to the Quarkus repo, I don't think it's a reasonable expectation. Creator/Owner of the PR is the primary responsible person and that's also why having a tool that would help identify incorrect syntax would help.

Hey, I don't blame anyone! :) It was all my fault. I will put this on my todo list.
I agree that this should be caught automatically.

[jmartisk]

We do have a bazillion documentation-related automated checks in the upstream CI, how come none of them caught this?

[jmartisk]

I guess the problem is that an unterminated ifndef/ifdef macro is actually legal, and the (asciidoc-maven-plugin) compiler in this case just treats the whole rest of the document (behind this macro) to be part of this macro, and doesn't throw any errors. And only Pantheon seems to handle it by failing (without a reasonable error message). To check for unterminated macros, we would have to write our own custom check, I think.