Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for OIDC client guides #43970

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

jedla97
Copy link
Contributor

@jedla97 jedla97 commented Oct 18, 2024

This fixes #37430 as I go through the guide. Only one thing is not resolved there but in my POV it's better not have it and leave it on the reader.

Also it seems that the default users was maybe changed in dev mode of Keycloak so I update it but the testing part using curl for get token but the guide setting the keycloak address to http://localhost:8180. I would assume this addres is when testing using own keycloak. In that case guide pointing to quickstart ream file which have user admin and alice.

Maybe it would be nice to update the reamls configs in quickstart and quarkus test be aligned with the dev mode. Probably up to discussion but if we want it I can find some time in next two week to do it.

Also the `ProtectedResource`'s is updated because it show in text like `ProtectedResource's . It's probably some edge case in ascii.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Oct 18, 2024
Copy link

github-actions bot commented Oct 18, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Oct 18, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ddc0163.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jedla97

@sberyozkin sberyozkin merged commit df778d4 into quarkusio:main Oct 18, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 18, 2024
@jedla97 jedla97 deleted the oidc-client-docs branch October 18, 2024 21:18
@jedla97
Copy link
Contributor Author

jedla97 commented Oct 18, 2024

Also @sberyozkin can you add backport for 3.15 as I doing it when reading RHBQ docs for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: OpenID Connect (OIDC) and OAuth2 Client and Filters Reference Guide
4 participants