-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC: Encapsulate static/dynamic tenants maps in TenantConfigBean
#43590
OIDC: Encapsulate static/dynamic tenants maps in TenantConfigBean
#43590
Conversation
Lets `TenantConfigBean` be the sole "owner" of the static/dynamic tenants maps, adds/changes accessor methods for tenants. Also introduces a functional interface to create tenants. No functional change, only moving code around.
🎊 PR Preview 1603d2c has been successfully built and deployed to https://quarkus-pr-main-43590-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/TenantConfigBean.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @snazy, I believe the iterations are going nicely now with yourself and @michalvavrik helping out, I can see now the light in the end of the tunnel :-), please wrap the dynamic map further once this PR is merged, proposal is do it similarly to for example the BackChannelLogoutCache. And then, later still, we can look at supporting the cache pluggability to support caffeine, etc, as you originally proposed
@michalvavrik Have a quick look please, I think this PR is good to go now, the orElseThrow()
in the create dynamic context does not harm, it is preceeded by an OIDC exception throw if the tenant id is null
Status for workflow
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Lets
TenantConfigBean
be the sole "owner" of the static/dynamic tenants maps, adds/changes accessor methods for tenants. Also introduces a functional interface to create tenants.No functional change, only moving code around.