Redis Cache: improve the API consistency #43468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
All the `get*` methods in the `RedisCache` API now have 3 variants: - not accepting value type, using the configured default - accepting value type as a `Class` - accepting value type as a `TypeLiteral` Internally, all these methods delegate to an implementation that takes a `Type`. The error message about the default value type was also consolidated into a single place, the `enforceDefaultType()` method.
640f169 to
8501412
Compare
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the
get*methods in theRedisCacheAPI now have 3 variants:ClassTypeLiteralInternally, all these methods delegate to an implementation that takes a
Type.The error message about the default value type was also consolidated into a single place, the
enforceDefaultType()method.Follows up on #43320