Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.15] 3.15.0 backports 1 #43284

Merged
merged 17 commits into from
Sep 14, 2024
Merged

[3.15] 3.15.0 backports 1 #43284

merged 17 commits into from
Sep 14, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Sep 13, 2024

Please don't merge, I will merge it myself.

ozangunalp and others added 16 commits September 13, 2024 18:00
Advanced review

Reverting some unwanted changes

Apply suggestions from code review

Feedback from the peer review.

Co-authored-by: Jiri Herrmann <jherrman@redhat.com>

Co-authored-by: Jan Martiska <jmartisk@redhat.com>
(cherry picked from commit c98d973)
Bumps com.gradle.plugin-publish from 1.2.2 to 1.3.0.

---
updated-dependencies:
- dependency-name: com.gradle.plugin-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 2b2e63b)
This now means that Quarkus will exit completely
even in dev-mode when the first start contains
the invalid reload configuration.
This might not be ideal, but it's far better than
the previous behavior where the application
was stuck and had to be killed with
`kill -9`

Fixes :quarkusio#43247
(cherry picked from commit adfc5bb)
Fixes quarkusio#43261

(cherry picked from commit e063f24)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Sep 13, 2024
@gsmet gsmet self-assigned this Sep 13, 2024
@quarkus-bot quarkus-bot bot changed the title 3.15.0 backports 1 [3.15] 3.15.0 backports 1 Sep 13, 2024
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kafka area/kafka-streams area/maven labels Sep 13, 2024
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/mongodb area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-messaging area/smallrye area/vertx area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kafka area/kafka-streams area/maven labels Sep 13, 2024

This comment has been minimized.

Copy link

github-actions bot commented Sep 13, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Sep 13, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f220a2b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Sep 13, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f220a2b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.timezone.ScheduledMethodTimeZoneTest.testScheduledJobs - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.scheduler.test.timezone.ScheduledMethodTimeZoneTest.testScheduledJobs(ScheduledMethodTimeZoneTest.java:70)

@gsmet gsmet merged commit be0632c into quarkusio:3.15 Sep 14, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/infra internal and infrastructure related issues area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kafka area/kafka-streams area/maven area/mongodb area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-messaging area/smallrye area/vertx triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants