Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend reflection configuration for VertX #43014

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 4, 2024

Doesn't seem to fix any functionality issues but prevents
MissingRegistrationErrors from being thrown when
ThrowMissingRegistrationErrors is enabled.

Related to quarkusio#41995

Trimmed down version of #42229 as discussed in #42229 (comment)

Doesn't seem to fix any functionality issues but prevents
`MissingRegistrationErrors` from being thrown when
`ThrowMissingRegistrationErrors` is enabled.

Related to quarkusio#41995
@zakkak zakkak requested a review from mkouba September 4, 2024 12:30
Copy link

quarkus-bot bot commented Sep 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 12062b7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 6e096fe into quarkusio:main Sep 4, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 4, 2024
@gsmet
Copy link
Member

gsmet commented Sep 4, 2024

Ah sorry, merged a bit too fast, I missed you asked Martin's review. @mkouba if anything is wrong, feel free to comment and we'll have to do a followup PR.

@zakkak zakkak deleted the 2024-09-04-vertx-reflections branch September 5, 2024 08:06
@mkouba
Copy link
Contributor

mkouba commented Sep 5, 2024

Ah sorry, merged a bit too fast, I missed you asked Martin's review. @mkouba if anything is wrong, feel free to comment and we'll have to do a followup PR.

That's fine ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants