Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a race condition in ReactiveDatasourceHealthCheck data field population #42260

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix a race condition in ReactiveDatasourceHealthCheck data field population #42260

merged 1 commit into from
Aug 2, 2024

Conversation

xstefank
Copy link
Member

@xstefank xstefank commented Aug 1, 2024 •
edited by geoand
Loading

I don't think we need a test for this but I can add it if someone thinks it's worth it.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor

geoand commented Aug 1, 2024

Can you update the title please? RC does not really convey much information here

@geoand
Copy link
Contributor

geoand commented Aug 1, 2024

I don't think we need a test for this but I can add it if someone thinks it's worth it.

I actually believe it would be nice to have as we clearly aren't testing the scenario that the user described

@gsmet gsmet changed the title Fix a RC in ReactiveDatasourceHealthCheck data field population Fix a race condition in ReactiveDatasourceHealthCheck data field population Aug 1, 2024
@xstefank xstefank force-pushed the incorrect-data-in-ReactiveDatasourceHealthCheck-42133 branch from 7d6d17a to 4feb838 Compare August 2, 2024 10:22
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@xstefank xstefank force-pushed the incorrect-data-in-ReactiveDatasourceHealthCheck-42133 branch from 4feb838 to 9ff2f52 Compare August 2, 2024 11:20
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor

geoand commented Aug 2, 2024

The failures definitelt seem related

@xstefank xstefank force-pushed the incorrect-data-in-ReactiveDatasourceHealthCheck-42133 branch from 9ff2f52 to 9d9534b Compare August 2, 2024 13:27
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Aug 2, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9d9534b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 0fecbde into quarkusio:main Aug 2, 2024
28 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 2, 2024
@xstefank xstefank deleted the incorrect-data-in-ReactiveDatasourceHealthCheck-42133 branch August 2, 2024 14:51
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.1 Aug 6, 2024
@gsmet
Copy link
Member

gsmet commented Aug 6, 2024

We need to check if it applies to 3.8.

@xstefank
Copy link
Member Author

@gsmet yes, this applies to 3.8.

@gsmet gsmet modified the milestones: 3.13.1, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/health area/reactive-sql-clients area/smallrye kind/bugfix
Projects
None yet
Milestone
3.8.6
Development

Successfully merging this pull request may close these issues.

Incorrect data in the ReactiveDatasourceHealthCheck being set when the connection is down
3 participants
@xstefank @geoand @gsmet