Clear com.sun.naming.internal.ResourceManager#propertiesCache #41723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This is only effective if the class is made accessible, which we make in our code. I noticed this a few times in my heap dumps and I noticed this was also handled in some other frameworks (until the switch to Java 9 that made the --add-opens mandatory). I think dealing with it in our codebase is a good idea from a sustainability point of view.
3f58397 to
38d9997
Compare
Status for workflow
|
gastaldi
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only effective if the class is made accessible, which we make in our code.
I noticed this a few times in my heap dumps and I noticed this was also handled in some other frameworks (until the switch to Java 9 that made the --add-opens mandatory).
I think dealing with it in our codebase is a good idea from a sustainability point of view.