Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VertxCurrentContextFactory: support multiple CDI contexts #38560

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 2, 2024

  • currently, only one scope can be backed by a vertx duplicated context at one time

@cescoffier This will be important for the new websocket API ;-)

@mkouba mkouba force-pushed the vertx-current-context-fix branch from e6e0fb8 to 320c96e Compare February 2, 2024 14:57
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Feb 2, 2024
@mkouba mkouba requested a review from Ladicek February 2, 2024 14:59

This comment has been minimized.

@mkouba mkouba force-pushed the vertx-current-context-fix branch from 320c96e to e6e2533 Compare February 5, 2024 08:03
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 5, 2024

This comment has been minimized.

@mkouba
Copy link
Contributor Author

mkouba commented Feb 5, 2024

The test failures are ofc related 🤦

- currently, only one scope can be backed by a vertx duplicated context
at one time
@mkouba mkouba force-pushed the vertx-current-context-fix branch from e6e2533 to 681b165 Compare February 5, 2024 14:13
Copy link

quarkus-bot bot commented Feb 5, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 681b165.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@mkouba mkouba merged commit 1fd25ca into quarkusio:main Feb 5, 2024
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 5, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/vertx triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants