Bring mvnw in line with the currently proposed Maven version 3.9.6

[famod]

Looks like this was forgotten in the last few update PRs, so e.g. CI is still running with 3.9.3.

Noticed via the warning at the beginning of the build:

[WARNING] Maven Wrapper is configured with a different version (3.9.3) than the runtime version (3.9.6). This will negatively impact build consistency and build caching.

(I usually rely on sdkman)

[famod]

What about mvnd in .sdkmanrc? It's still on m7 / Maven 3.9.3 and m8 is available which is using Maven 3.9.5, at least.
I think it would make sense to add maven too?

[gsmet]

Actually I don't want us to do that.

What are you doing exactly to get this warning?

[gsmet]

Sorry the rationale is that 3.9.3 is the only version for which we have a corresponding mvnd.

[famod]

Hm, so we are not eating our own dog food? Interesting.
What about m8 of mvnd? Not working?
Didn't know we let mvnd dictate which Maven version CI is allowed to run. Now I know. 😉

[famod]

What are you doing exactly to get this warning?

I'm just running mvn, which was added to PATH via sdk install maven 3.9.6 some days ago (and 3.9.5 before that).

[gsmet]

I should have given more details, sorry, was working on something else.

The new build cache we added is dependent on the version of Maven. If you want to use the build cache, you need to use the exact same version as the version used to produce the build cache.

We want people using Maven and mvnd to be able to use the build cache, thus why we settled on 3.9.3. It's not ideal but it works.

As for your suggestion of adding it to .sdkmanrc, please go ahead!

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[famod]

@gsmet Ok, thank for the details!

What I still don't get is whether Maven 3.9.5 and mvnd 1.0-m8-m39 would work or not - or is it the caching setup itself that needs Maven 3.9.3?
Right now there is 1.0-m7-m39 in sdkmanrc.