Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HttpSecurityProcessor compilation by importing Singleton #37030

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Nov 12, 2023

I suppose it's consequence of merging both #37022 and #37017.

@michalvavrik
Copy link
Member Author

cc @sberyozkin this needs to go in ASAP, I'm sorry for troubles (but it's Sunday evening, so hopefully it shouldn't affect too many people)

@sberyozkin
Copy link
Member

Np, not sure why the basic auth PR did not show any conflicts

@sberyozkin sberyozkin self-requested a review November 12, 2023 20:47
@michalvavrik michalvavrik removed the request for review from geoand November 12, 2023 21:14
Copy link

quarkus-bot bot commented Nov 13, 2023

Failing Jobs - Building a94eb39

Status Name Step Failures Logs Raw logs Build scan
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.CustomManifestArgumentsTest.shouldContainsSpecificManifestProperty line 37 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual not to be null

@phillip-kruger phillip-kruger merged commit d61be87 into quarkusio:main Nov 13, 2023
50 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 13, 2023
@michalvavrik michalvavrik deleted the feature/fix-http-sec-proc-compilation branch November 13, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants