-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to generate gRPC descriptor set #36930
Conversation
The majority of the 50 changed files are new integration tests that I added. |
f1df49b
to
1fb9e23
Compare
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a * import to fix. The rest looks good. I've asked Aleš and Alexei to have a look for the gRPPC protoc part and maven/gradle part.
extensions/grpc/codegen/src/main/java/io/quarkus/grpc/deployment/GrpcCodeGen.java
Outdated
Show resolved
Hide resolved
extensions/grpc/codegen/src/main/java/io/quarkus/grpc/deployment/GrpcCodeGen.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
14cd1e1
to
43b7e08
Compare
Failing Jobs - Building 43b7e08
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
@gsmet I'm not sure whats up with that Gradle integration test. I see it failing on other PRs as well, so I'm not sure I did anything here that would cause that failure. |
Hi, I appreciate the new feature of generating the descriptor file a lot because I would like to use this for WireMock. However, I am not able to generate it. While ...
I am getting the warning that the key cannot be found: |
Hi @johannesctrl have you tried it with 3.6.0 (the released version)? Using it with Wiremock is exactly why I did this PR in the first place :) |
@johannesctrl I just added that to the You can customize the name & location of the file by using the quarkus:
generate-code:
grpc:
descriptor-set:
generate: true
output-dir: .
name: locationservice-v1.dsc |
Thank you so much for checking! :) Yes, I already tried the 3.6.0 version and also using the name and location properties. Maybe it's something else in my settings ... I'm gonna check all my settings again, I guess 😄 |
You can look in the the All I did was clone that and run
You could also add the properties to |
Ability to generate gRPC descriptor sets.
@cescoffier please take a look. In the code gen I needed a way to get access to the project root directory so that the user could specify an output directory relative to that. I modified the Maven & Gradle plugins to provide that info into the generation. I also added a bunch of tests to both plugins.
Fixes #36897