Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] security-oidc-auth0-tutorial.adoc improvements #36906

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Nov 6, 2023

…tutorial.adoc

Purpose: [Docs] Final edits, QE and publishing prep work: security-oidc-auth0-tutorial.adoc as described in QDOCS-534

Copy link

quarkus-bot bot commented Nov 6, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)
  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@sberyozkin
Copy link
Member

Thanks @rolfedh for these edits, I'll have a look tomorrow, this PR will be good to go in, but I'm not sure yet about #36905

@sberyozkin
Copy link
Member

I apologize in advance if these edits won't have effect on the product docs :-), we'll discuss #36905

Copy link

github-actions bot commented Nov 6, 2023

🙈 The PR is closed and the preview is expired.

@rolfedh rolfedh marked this pull request as draft November 7, 2023 07:42
@rolfedh rolfedh requested a review from sberyozkin November 7, 2023 07:42
@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 7, 2023

No worries, @sberyozkin. Thanks.

@rolfedh rolfedh closed this Nov 7, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Nov 7, 2023
@sberyozkin sberyozkin reopened this Nov 7, 2023
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Nov 7, 2023
@sberyozkin sberyozkin changed the title [Docs] Final edits, QE and publishing prep work: security-oidc-auth0-… [Docs] security-oidc-auth0-tutorial.adoc improvements Nov 7, 2023
@sberyozkin
Copy link
Member

Hey @rolfedh, I'd not like to lose the fixes you have made to this file, I'll have a look soon, at the very least they will make it upstream :-), this is what I meant, they will be applied, but may not end up in the product if the doc itself is not pushed down to the product, thanks

@rolfedh rolfedh marked this pull request as ready for review November 7, 2023 11:24
…tutorial.adoc

Co-Authored-By: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
@rolfedh rolfedh force-pushed the required-edits-for-security-oidc-auth0-tutorial branch from 6708588 to 7f3c16b Compare November 7, 2023 11:25
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, Rolfe

@sberyozkin sberyozkin merged commit 422cefb into quarkusio:main Nov 7, 2023
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 7, 2023
@gsmet gsmet modified the milestones: 3.6 - main, 3.5.1 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants