Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note that pinning cases section is historical information. #36553

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add note that pinning cases section is historical information. #36553

merged 1 commit into from
Oct 20, 2023

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Oct 18, 2023

Fixes #33337

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 18, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

gsmet
gsmet requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will let @cescoffier review it but these should be fixed.

docs/src/main/asciidoc/virtual-threads.adoc Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@rolfedh rolfedh force-pushed the pinning-obsolete branch 3 times, most recently from cc3c4fa to 7bd19b0 Compare October 18, 2023 14:32
@davecramer
Copy link

LGTM! Thanks

@rolfedh
Copy link
Contributor Author

rolfedh commented Oct 18, 2023

Hi, @cescoffier. Please review and approve. Thanks.

@rolfedh rolfedh force-pushed the pinning-obsolete branch 4 times, most recently from 7454f68 to 97731f3 Compare October 18, 2023 19:11
@rolfedh
Copy link
Contributor Author

rolfedh commented Oct 20, 2023

@gsmet, would you please merge this PR? Thanks.

@cescoffier cescoffier merged commit aa3dd90 into quarkusio:main Oct 20, 2023
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet requested changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
Quarkus Documentation
Status: Done
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.

Thread pinning with PostgreSQL JDBC driver
4 participants
@rolfedh @davecramer @cescoffier @gsmet