Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or replace Pinning cases? #36422

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Remove or replace Pinning cases? #36422

merged 1 commit into from
Oct 16, 2023

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Oct 11, 2023

It's unclear from this issue, Thread pinning with PostgreSQL JDBC driver #33337 , whether to simply remove the section or replace it with new information.

@rolfedh rolfedh requested a review from cescoffier October 11, 2023 18:29
@cescoffier
Copy link
Member

Why do you want to remove this section? It is accurate and important.

@cescoffier
Copy link
Member

The text says 'old' version of the driver.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@rolfedh
Copy link
Contributor Author

rolfedh commented Oct 11, 2023 •
edited
Loading

Thanks, @cescoffier.
I should have messaged you to clarify my intentions: At this stage, the purpose of the PR is to have a conversation about the content.
Are you saying that no revisions are needed and we can close the issue?
If revisions are needed, please suggest specific edits. I have restored the content and used comments so that it is visible for that purpose.
I'll remove the comments when no more revisions are needed.

@cescoffier
Copy link
Member

The content is accurate. The only thing I would add is a link to the blog post: https://quarkus.io/blog/virtual-thread-1/

cescoffier
cescoffier requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is accurate, do not remove it.

@rolfedh
Copy link
Contributor Author

rolfedh commented Oct 16, 2023 •
edited
Loading

It looks like no significant changes are required. I've added a link to the blog post, When Quarkus meets Virtual Threads
, recommended by @cescoffier.

@rolfedh
Copy link
Contributor Author

rolfedh commented Oct 16, 2023 •
edited
Loading

@cescoffier please review and approve to clear the "Changes requested" flag so we can merge this PR. Thank you.

@cescoffier cescoffier merged commit e30bae3 into quarkusio:main Oct 16, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
Quarkus Documentation
Status: Done
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@rolfedh @cescoffier