-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc style and link enhancements #35897
Doc style and link enhancements #35897
Conversation
58b1b9f
to
1a02aef
Compare
1a02aef
to
4c9ff7a
Compare
4c9ff7a
to
e328a27
Compare
6290efc
to
360788a
Compare
This comment has been minimized.
This comment has been minimized.
360788a
to
2b77327
Compare
This comment has been minimized.
This comment has been minimized.
357670d
to
fe69b70
Compare
docs/src/main/asciidoc/security-oidc-bearer-token-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-bearer-token-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-bearer-token-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-bearer-token-authentication.adoc
Outdated
Show resolved
Hide resolved
fe69b70
to
c6b6cb2
Compare
Looks like it was cancelled and I missed merging it. |
It is upstream only though so let me merge it now, though I'll rebase |
d4559bb
to
ce6a2f0
Compare
Hmm, |
@gsmet I'm not sure why this PR is hanging, I don't see anything in the updated doc that could've caused it. Please review and merge if it looks fine. on PTO tomorrow |
@sheilamjones, @inoxx03, Hi - what is |
@sberyozkin Thasnk for the head's up. TBH, I have not found the cause yet. trheI'm not sure but I'll come back and investigate further today, just have to finish some release-related tasks. |
ce6a2f0
to
d91871b
Compare
Apologies for slow reply @sberyozkin. Was tied up with 3.2 release tasks yesterday. Yes, as Stefan suggested, I think the assemble-downstream.doc topic relates to the downstreaming script with the post-processing fixes to enable us to bring the content downstream. Shall investigate further. |
@sheilamjones No problems at all Sheila, thanks for the update. Unfortunately it is still failing, something in this PR or in some other PRs is causing this task to fail. @rsvoboda Rostislav, can you spot it ? Your fix is in Michelle's branch: https://github.com/michelle-purcell/quarkus/commits/security-doc-fixes-3-2-bearer-concept |
+ | ||
==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This noise makes the build of downstream docs to be stuck
there should be no +
and ====
on solo lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rsvoboda @michelle-purcell It took me may be 5 rounds to get past the downstream task, I've ended up removing all of standalone +
and ====
and it looked like it fixed the problem. Michelle, not sure if the end result would be what you expected it to be without these characters, so I guess you should have a look before me merging this PR
Thanks
🙈 The PR is closed and the preview is expired. |
556808f
to
d5e32b2
Compare
Michelle, I'm not sure the numbering scheme works, there are a few places with |
d5e32b2
to
8888625
Compare
fix typo Fixes Minor fixes fix fix remove html file Peer review fixes Fixes to section headings level 3 fix minortweak Update docs/src/main/asciidoc/security-oidc-bearer-token-authentication.adoc Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com> Update docs/src/main/asciidoc/security-oidc-bearer-token-authentication.adoc fix
Thanks @sberyozkin. Apologies for not getting to this sooner. Between PTO and other priorities... |
Hi Michelle @michelle-purcell , missed your comment, sorry. Sure please check it |
@sheilamjones has taken up revising this guide. I've conveyed this information to her. Thanks. |
This PR fixes style issues (title capitalization, one sentence per line...), links, and some grammar as per the preferred Quarkus Contributor guidelines for writing tutorials.
This also harmonizes the content with product docs downstream for the 3.2 release.